[WIP] Feat/debug accept message error #210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 64.82% 65.00% +0.17%
==========================================
Files 25 25
Lines 2607 2626 +19
==========================================
+ Hits 1690 1707 +17
- Misses 573 575 +2
Partials 344 344
Continue to review full report at Codecov.
|
nonsense
reviewed
May 26, 2021
impl/events.go
Outdated
|
|
||
| result, err := validatorFunc(isRestart, sender, vouch, baseCid, stor) | ||
| if isPull { | ||
| log.Infof("\n ValidatePull, result=%s, err=%s", result, err) |
Member
There was a problem hiding this comment.
Nit: Not sure why we have \n inside a log.Infof
nonsense
reviewed
May 26, 2021
transport/graphsync/graphsync.go
Outdated
| // when a DT request comes in on graphsync, it's a pull | ||
| chid = datatransfer.ChannelID{ID: msg.TransferID(), Initiator: p, Responder: t.peerID} | ||
| request := msg.(datatransfer.Request) | ||
| log.Debugf("will validate recieved gs request, chid=%s, request=%+v", chid, request) |
Member
There was a problem hiding this comment.
Suggested change
| log.Debugf("will validate recieved gs request, chid=%s, request=%+v", chid, request) | |
| log.Debugf("will validate received gs request, chid=%s, request=%+v", chid, request) |
nonsense
reviewed
May 26, 2021
transport/graphsync/graphsync.go
Outdated
| return nil, t.events.OnResponseReceived(chid, dtResponse) | ||
| err = t.events.OnResponseReceived(chid, dtResponse) | ||
| if err != nil { | ||
| log.Errorf("\n error receieved from OnResponseReceived is %s", err) |
Member
There was a problem hiding this comment.
Same comment here - why \n at the start?
nonsense
reviewed
May 26, 2021
impl/events.go
Outdated
| if response.IsVoucherResult() { | ||
| log.Infof("channel %s: received response %+v from provider is a voucher result", chid, response) | ||
| if !response.EmptyVoucherResult() { | ||
| log.Debug("processing non-empty voucher result") |
Member
There was a problem hiding this comment.
Maybe add the chid as part of this logline, so that we can correlate to which channel this refers?
nonsense
approved these changes
May 26, 2021
Member
nonsense
left a comment
nonsense
left a comment
There was a problem hiding this comment.
added a few comments, that it'd be good to be addressed, but overall lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help debug the missing
Acceptmessages on dealbot clients.